This section allows you to view all posts made by this member. Note that you can only see posts made in areas you currently have access to.
Quote from: tomaskir on September 12, 2019, 12:11:15 PMQuote from: Victor Kirhenshtein on September 12, 2019, 11:10:31 AM
That's complicated issue. Current implementation is a bit messy with $n variables after matching. Consider the following code:Code Select
v = "error 43";
if (v ~= "(error|warning) ([0-9]+)")
println("Step 1: $1=".$1." $2=".$2);
if (v ~= "(error .*|info ([0-9]+))")
println("Step 2: $1=".$1." $2=".$2);
In NetXMS 2.2 $2 will be equal "43" on step 2, which is kind of misleading. It was because implementation in 2.2 silently skipping unmatched capture groups. Implementation in 3.0 resets all unused $n variables, which has side effect of clearing $1 if there were no capture groups at all. Looks like it was bad decision to use same names for capture groups and script arguments.
I want to gradually clean up inconsistencies in NXSL, and that could lead to break up of some things. I think that for now I can introduce server configuration variable (off by default) that will prevent resetting of unused capture group variables. Also I will introduce separated naming for script arguments and capture groups so scripts could be migrated over time to non-overlapping variable naming. Also for transformation scripts I think it is worth passing raw value not only as first argument to the script but also as global variable, like $rawValue.
Best regards,
Victor
The problem here is that there are likely thousands of scripts all around the Forums, Wiki and the internet that this change breaks.
Every single one would have to be updated - which is unrealistic.
For new users who find some regex-based scripts on the internet, they will not work, and they don't know why.
Existing implementations (scripts) will start working differently upon upgrade, without any knowledge of the system operators
This will be VERY difficult to track down, as this will not produce script errors, rather things will just work differently.
This means there can be a threshold script which will "pretend" to still work, but in reality will not work.
It puts burden on system operators to review every script they have upon upgrade to check if it still works properly
What I personally would propose:
There are far less scripts using regex capture groups than just regex.
So if a change is needed, only regex capture group should be changed, without affecting regex operations without capture groups (as is the case now).
What about capturing regex returning arrays with captures?Code Select
matchArrray = "test" ~= "t(e)(s)t";
println(matchArrray [0] . matchArrray [1]);
for (match : matchArrray) {
print(match);
}
This would clean up the reuse of $1, $2, etc. without breaking ALL regex handling.
The change would only affect a smaller part of community, so less impact.
text = "error 43";
errorCode = (text ~= "error ([0-9]+)")[1];
println(errorCode);
SetCustomAttribute($node, "timelastcameup", strftime("%d-%m-%Y, %H:%M:%S", $1));
Quote from: vir_db on September 12, 2019, 12:05:24 PM
Good morning.
just upraded to 3.0: more or less all hosts reports this alarm: Status of DCI xxxx (NetXMS Agent: sqlite-hosts) changed to UNSUPPORTED. (seems it comes from "Local Database" template)
just the server itself reports:
- Status of DCI 697 (Internal: Server.ThreadPool.Usage(SYNCER)) changed to UNSUPPORTED
- Status of DCI 696 (Internal: Server.ThreadPool.LoadAverage(SYNCER,1)) changed to UNSUPPORTED
- Status of DCI 695 (Internal: Server.ThreadPool.CurrSize(SYNCER)) changed to UNSUPPORTED
- Status of DCI 694 (Internal: Server.ThreadPool.Load(SYNCER)) changed to UNSUPPORTED
looking at Data Collection Configuration, those DCIs doesn't exists.
Also tried to delete the database (PGSQL) and have a fresh start, but the results is the same.
How can I solve?
thanks alot and best regards
Quote from: tomaskir on September 12, 2019, 02:36:19 AMQuote from: Tursiops on September 12, 2019, 02:16:29 AM
Just a practical note on this one:Quote1. We have switched from TRE to PCRE as regular expression engine. In most cases this should go unnoticed, but in certain cases regular expressions may stop working or produce unexpected results.
A side effect of this change is that if you are matching a regular expression, even without a capture group, $1, $2, etc. will be reset to null values.
An transform script example of where that might cause an issue:Code Selectif ( $1 ~= "^Hello\s+World" ) {
return $1;
} else {
return "Something Else";
}
In prior versions of NetXMS, if the DCI returned "Hello World", the transform script would have returned exactly that.
With version 3, the transform script will return null.
You will need to change your script to something like this:Code Selectvalue = $1;
if ( value ~= "^Hello\s+World" ) {
return value;
} else {
return "Something Else";
}
Is this a known and expected change or a bug?
This will break A LOT of my NXSL scripts...
v = "error 43";
if (v ~= "(error|warning) ([0-9]+)")
println("Step 1: $1=".$1." $2=".$2);
if (v ~= "(error .*|info ([0-9]+))")
println("Step 2: $1=".$1." $2=".$2);
Quote from: brettmilfos on September 12, 2019, 06:59:17 AM
Just upgraded and have found an issue with SMS.
It created the migrated notification channel but did not work.
I tried to create a new notification channel, but there is nothing to select in the Driver name drop down.
Thanks, Brett.
Ну и конечно всегда можно сделать пожертвование через PayPal на [email protected], мы будем рады У нас раньше была кнопка на сайте, но при обновлении сайта пропала.