NetXMS Support Forum

Actual code that caused crash looked like this:

   int bytes = request->packetSize - sizeof(IPHDR);
   packet.m_icmpHdr.m_wChecksum = 0;
   packet.m_icmpHdr.m_wChecksum = CalculateIPChecksum(&packet, bytes);


If total packet size < 20, bytes will be negative, which will cause crash within CalculateIPChecksum. With packet size between 20 and 27, result will be positive and CalculateIPChecksum will actually calculate checksum for requested number of bytes, but invalid ICMP packet will be sent (with only part of the header).

Best regards,
Victor

Try to deploy new web under different name - will it have same issue?

Looks like old client version still deployed, or some parts of old version stuck in cache. Try to clear Tomcat working directory.

Best regards,
Victor

Quote from: troffasky on May 12, 2022, 04:18:36 PM
Is it worth bringing these up here?

Yes, absolutely. We will look into it and hopefully fix before next patch release.

Best regards,
Victor

Fixed it just an hour ago Fix will be included into next patch release.

Best regards,
Victor

Documentation is wrong, I checked source code Will fix that.

Actually as I start thinking about it, minimum size is 28, not 46. Because this value includes both IP header (20 bytes) and ICMP header (8 bytes), it cannot be less than that. 46 is minimum payload size for Ethernet frame. If you are using only Ethernet for communications, setting ping size to any value less than 46 will not reduce traffic, as payload will be padded to minimum length anyway. However, if you are using communication channels capable of sending shorter frames than reducing ping size further can make sense.

Hi,

looks like you have server configuration parameter ICMP.PingSize set to 1 (or other small value). It has to be set to at least 46. There is a bug in a server that it does not check this value for validity, and incorrect value causes crash later on.

Best regards,
Victor

session.findObjectById(objectID).getObjectId() is kind of pointless - you already know object ID, but you use it to find object by that ID, only to get that same ID from object...

Yes, that makes sense. I've added it as feature request: https://track.radensolutions.com/issue/NX-2260

Best regards,
Victor

Hi,

try to set MailEncoding to utf-8.

Best regards,
Victor

Argument for setTrustedNodes is array of object identifiers, not array of objects, so probably something like this will work:
data.setTrustedNodes([trustedNodeId])
where trustedNodeId is an ID of node to be set as trusted.

Best regards,
Victor

Go to Configuration -> Scheduled Tasks. Create new task, select Maintenance.Enter for type, and object you want to put into maintenance as "execution object". In schedule, enter desired schedule in crontab format. Create another task with type Maintenance.Leace and set schedule for exiting from maintenance.

Best regards,
Victor

We are looking for C++ and Java developers to join our small but dedicated team in Riga - either on-site or remotely.
If you are interested, contact me via PM on the forum, or drop an email to [email protected].

C++ Developer

Expected experience:
Strong software development skills with C or C++
University degree in Computer Science or related technical field or equivalent practical experience
Good communication and teamwork skills
Professional curiosity, ability to learn fast, and willingness to share knowledge
Ability to work in a dynamic environment

Seen as an advantage:
Analytical skills and willingness to drive team success
Knowledge of Java
Knowledge of SQL
Understanding of network protocols and technologies

We offer:
Challenging job responsibilities and flexible work schedule
Interesting and dynamic work environment
Professional and personal development opportunities
Motivating salary and benefits package (health insurance, etc.)


Java Developer

Expected experience:
Strong software development skills with Java
University degree in Computer Science or related technical field or equivalent practical experience
Good communication and teamwork skills
Professional curiosity, ability to learn fast, and willingness to share knowledge
Ability to work in a dynamic environment

Seen as an advantage:
Analytical skills and willingness to drive team success
Understanding of UI development principles
Understanding of network protocols and technologies
Knowledge of C or C++
Knowledge of JavaScript

We offer:
Challenging job responsibilities and flexible work schedule
Interesting and dynamic work environment
Professional and personal development opportunities
Motivating salary and benefits package (health insurance, etc.)

Hi,

one option is to schedule recurring maintenance - node will enter maintenance mode at non-business hours and all events will be suppressed until end of maintenance period. If node will still be down at end of maintenance appropriate events will be generated again so you will get notifications, etc.

Another option is to define rule in event processing policy that will drop all events from those nodes during non-business hours.

Best regards,
Victor